[HBASE-26580] The message of StoreTooBusy is confused

• Type: Task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-2, 2.4.10
• Component/s: logging, regionserver
• Hadoop Flags: Reviewed
• Assignee: zhuobin zheng
• Reporter: zhuobin zheng
• Created: 15/Dec/21 10:49
• Updated: 19/Dec/21 18:43
• Resolved: 18/Dec/21 15:37

Description

 

When check Store limit. We both check parallelPutToStoreThreadLimit and parallelPreparePutToStoreThreadLimit. 

if (store.getCurrentParallelPutCount() > this.parallelPutToStoreThreadLimit
    || preparePutCount > this.parallelPreparePutToStoreThreadLimit) {
  tooBusyStore = (tooBusyStore == null ?
      store.getColumnFamilyName() :
      tooBusyStore + "," + store.getColumnFamilyName());
} 

But we only print Above parallelPutToStoreThreadLimit only. 

 

 

if (tooBusyStore != null) {
  String msg =
      "StoreTooBusy," + this.region.getRegionInfo().getRegionNameAsString() + ":" + tooBusyStore
          + " Above parallelPutToStoreThreadLimit(" + this.parallelPutToStoreThreadLimit + ")";
  if (LOG.isTraceEnabled()) {
    LOG.trace(msg);
  }
  throw new RegionTooBusyException(msg);
}

It confused me a lot time ...... 

Just add message of parallelPreparePutToStoreThreadLimit

 

Issue Links

• links to: GitHub Pull Request #3949