[HBASE-25911] Fix uses of System.currentTimeMillis (should be EnvironmentEdgeManager.currentTime)

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 25/May/21 00:05
• Updated: 02/Jun/21 18:19
• Resolved: 01/Jun/21 23:08

Description

We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all callers that would otherwise use System.currentTimeMillis() must call EnvironmentEdgeManager.currentTime() instead, except obviously the implementors of EnvironmentEdge.

It's common for contributors to be unaware of this practice and reviewers might not catch it.

It will be much more important to have EnvironmentEdgeManager in use where expected once we have EnvironmentEdge also providing a monotonic clock source. (See parent.)

On another subtask I will introduce a build enforcer that bans System.currentTimeMillis() except where annotated to allow it.

 

Issue Links

• links to: GitHub Pull Request #3302