Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-25685

asyncprofiler2.0 no longer supports svg; wants html

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha-1, 2.5.0, 2.3.5, 2.4.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      If asyncprofiler 1.x, all is good. If asyncprofiler 2.x and it is hbase-2.3.x or hbase-2.4.x, add '?output=html' to get flamegraphs from the profiler.

      Otherwise, if hbase-2.5+ and asyncprofiler2, all works. If asyncprofiler1 and hbase-2.5+, you may have to add '?output=svg' to the query.
      Show
      If asyncprofiler 1.x, all is good. If asyncprofiler 2.x and it is hbase-2.3.x or hbase-2.4.x, add '?output=html' to get flamegraphs from the profiler. Otherwise, if hbase-2.5+ and asyncprofiler2, all works. If asyncprofiler1 and hbase-2.5+, you may have to add '?output=svg' to the query.

      Description

      asyncprofiler2.0 is out. Its a nice tool. Unfortunately, it dropped the svg formatting option that we use in our servlet. Now it wants you to pass html. Lets fix.

      Old -o on asyncprofiler1.x
      -o fmt output format: summary|traces|flat|collapsed|svg|tree|jfr

      New -o asyncprofiler 2.x
      -o fmt output format: flat|traces|collapsed|flamegraph|tree|jfr

      If you pass svg to 2.0, it does nothing ... If you run the command hbase is running you see:

      /tmp/prof-output$ sudo -u hbase /usr/lib/async-profiler/profiler.sh -e cpu -d 10 -o svg -f /tmp/prof-output/async-prof-pid-8346-cpu-1x.svg 8346
      [ERROR] SVG format is obsolete, use .html for FlameGraph
      

      At a minimum can make it so the OUTPUT param supports HTML. Here is current enum state:

        enum Output {
          SUMMARY,
          TRACES,
          FLAT,
          COLLAPSED,
          SVG,
          TREE,
          JFR
        }
      

        Attachments

          Activity

            People

            • Assignee:
              stack Michael Stack
              Reporter:
              stack Michael Stack
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: