[HBASE-25449] 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.1
• Fix Version/s: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
• Component/s: conf
• Hadoop Flags: Reviewed
• Release Note: The presence of HDFS short-circuit read configuration properties in hbase-default.xml inadvertently causes short-circuit reads to not happen inside of RegionServers, despite short-circuit reads being enabled in hdfs-site.xml.
• Assignee: shenshengli
• Reporter: shenshengli
• Created: 28/Dec/20 08:18
• Updated: 01/Jul/22 21:43
• Resolved: 14/Jan/21 02:25

Description

I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to "dfs.client.read.shortcircuit=true" to take effect.The same goes for the parameter 'dfs.domain.socket.path', which is already covered in the specific change.

Issue Links

• is caused by: HBASE-14532 [book] dfs.client.read.shortcircuit is referenced as hbase-site.xml config and not described in section 7
• links to: GitHub Pull Request #2816
• links to: GitHub Pull Request #2878