[HBASE-25370] Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

• Type: Test
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
• Component/s: test
• Hadoop Flags: Reviewed
• External issue URL: https://github.com/apache/hbase/pull/2740
• Assignee: Adam Wang
• Reporter: Adam Wang
• Created: 08/Dec/20 01:52
• Updated: 12/Dec/20 20:08
• Resolved: 11/Dec/20 00:29

Description

The test TestClassFinder#testClassFinderDefaultsToOwnPackage compares two sets from allClassesFinder.findClasses. However, the function allClassesFinder.findClasses does not return the deterministic order result. From code trace, the root cause is at ClassFinder.findClassesFromJar and ClassFinder.findClassesFromFiles. They use HashSet to store classes and listFiles to get file array. However, HashSet and listFiles do not guarantee that order, and the assertion can fail if the order differs.

Issue Links

• links to: GitHub Pull Request #2740