[HBASE-25117] ReplicationSourceShipper thread can not be finished

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.4.0, 2.2.6, 2.3.2
• Fix Version/s: 3.0.0-alpha-1, 2.3.3, 2.4.0, 2.2.7
• Assignee: Sun Xin
• Reporter: Sun Xin
• Created: 29/Sep/20 10:43
• Updated: 15/Oct/20 17:03
• Resolved: 14/Oct/20 17:38

Description

See Flaky Tests, some UTs about replication failed cause timeout.

In HBaseInterClusterReplicationEndpoint.sleepForRetries, InterruptedException is caught but no further processing, the interrupted status of the current thread is cleared.

Below is the code comment of Thread.sleep.

/**
 * ...
 *
 * @throws  InterruptedException
 *          if any thread has interrupted the current thread. The
 *          <i>interrupted status</i> of the current thread is
 *          cleared when this exception is thrown.
 */
public static native void sleep(long millis) throws InterruptedException;

So InterruptedException must be processed, otherwise ReplicationSourceShipper thread cannot be terminated in some cases.

Issue Links

• is broken by: HBASE-24813 ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination
• links to: GitHub Pull Request #2521