[HBASE-25091] Move LogComparator from ReplicationSource to AbstractFSWALProvider#.WALsStartTimeComparator

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.4.0
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 23/Sep/20 18:11
• Updated: 05/Oct/20 09:25
• Resolved: 01/Oct/20 17:20

Description

Minor cleanup item noticed playing over in HBASE-18070.

ReplicationSource has an inner class named LogComparator which is a pretty generic name for the comparator only it just compares on WAL start time and nothing else.

Also, messing in HBASE-18070 I ran into compares that included user-space WALs and hbase:meta WALs. The LogComparator as is barfed on meta WALs.

This ticket moves the comparator to AbstractFSWALProvider, where folks will go looking if they need WAL comparators, and it also renames it to more clearly explain what it does (and makes it so it can compare start times even if it a meta WAL).

 

Issue Links

• links to: GitHub Pull Request #2449