HBase
  1. HBase
  2. HBASE-2507

HTable#flushCommits() - event notification handler

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Coprocessors

      Description

      Event notification handler code when flushing commits on the client side. By default is null.

      New Class - CommitEventHandler , HTableCommitEvent .

      notification data - preSize, postSize .

        Activity

        Hide
        stack added a comment -

        What you thinking Kay Kay? You didn't want to just subclass HTable? Seems like you could have gotten what you wanted doing just a subclass? Thanks.

        Show
        stack added a comment - What you thinking Kay Kay? You didn't want to just subclass HTable? Seems like you could have gotten what you wanted doing just a subclass? Thanks.
        Hide
        ryan rawson added a comment -

        If we really want to do this, we should be using type safe notions, not a map of String -> String.

        But perhaps Stack is right - a custom subclass?

        Show
        ryan rawson added a comment - If we really want to do this, we should be using type safe notions, not a map of String -> String. But perhaps Stack is right - a custom subclass?
        Hide
        stack added a comment -

        Bulk move of 0.20.5 issues into 0.21.0 after vote that we merge branch into TRUNK up on list.

        Show
        stack added a comment - Bulk move of 0.20.5 issues into 0.21.0 after vote that we merge branch into TRUNK up on list.
        Hide
        Karthik K added a comment -

        True - stack/ ryan, could have gotten this using the public , overriding flushCommits() . Somehow , was not very comfortable with disturbing that functionality. Can we have flushCommits() as final and have a pre/postFlushCommits() hook for people to do otherwise ?

        Show
        Karthik K added a comment - True - stack/ ryan, could have gotten this using the public , overriding flushCommits() . Somehow , was not very comfortable with disturbing that functionality. Can we have flushCommits() as final and have a pre/postFlushCommits() hook for people to do otherwise ?
        Hide
        stack added a comment -

        Moved from 0.21 to 0.22 just after merge of old 0.20 branch into TRUNK.

        Show
        stack added a comment - Moved from 0.21 to 0.22 just after merge of old 0.20 branch into TRUNK.
        Hide
        stack added a comment -

        Would the pre/post be protected? You'd subclass to override? If so, seems fine (This is what you are saying I believe). Else, just make flushCommits public.

        Show
        stack added a comment - Would the pre/post be protected? You'd subclass to override? If so, seems fine (This is what you are saying I believe). Else, just make flushCommits public.
        Hide
        stack added a comment -

        Cancelling stale patch. This should be done as a coprocessor now anyways?

        Show
        stack added a comment - Cancelling stale patch. This should be done as a coprocessor now anyways?
        Hide
        stack added a comment -

        Moving out of 0.92.0. Pull it back in if you think different.

        Show
        stack added a comment - Moving out of 0.92.0. Pull it back in if you think different.

          People

          • Assignee:
            Unassigned
            Reporter:
            Karthik K
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development