[HBASE-24973] Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.4.0
• Assignee: yuqi
• Reporter: yuqi
• Created: 01/Sep/20 02:09
• Updated: 03/Sep/20 15:40
• Resolved: 02/Sep/20 10:14

Description

Currently, read point parameter in method StoreFlush#performFlush is useless and can be safely removed.
and then method StoreFlush#createScanner can also remove this parameter
See below

// Some comments here
  /**
   * Performs memstore flush, writing data from scanner into sink.
   * @param scanner Scanner to get data from.
   * @param sink Sink to write data to. Could be StoreFile.Writer.
   * @param smallestReadPoint Smallest read point used for the flush.
   * @param throughputController A controller to avoid flush too fast
   */
  protected void performFlush(InternalScanner scanner, CellSink sink,
      long smallestReadPoint, ThroughputController throughputController) throws IOException

Parameter smallestReadPoint is not used in this method. When `smallestReadPoint` is removed, inner method `createScanner` can remove this necessary parameter too

Issue Links

• links to: GitHub Pull Request #2337