[HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0, 1.3.6, 1.7.0
• Fix Version/s: 1.7.0
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Rushabh Shah
• Reporter: Rushabh Shah
• Created: 27/Aug/20 01:47
• Updated: 02/Sep/20 16:07
• Resolved: 01/Sep/20 08:35

Description

The following bug exists only in branch-1 and below.

ZKTableStateClientSideReader#isDisabledTable returns false even if table doesn't exists.

Below is the code snippet:

 

ZKTableStateClientSideReader.java

  public static boolean isDisabledTable(final ZooKeeperWatcher zkw,
      final TableName tableName)
      throws KeeperException, InterruptedException {
    ZooKeeperProtos.Table.State state = getTableState(zkw, tableName);    ---> We should check here if state is null or not.
    return isTableState(ZooKeeperProtos.Table.State.DISABLED, state);
  }
}

 

Issue Links

• links to: GitHub Pull Request #2323