[HBASE-24871] Replication may loss data when refresh recovered replication sources

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.5
• Fix Version/s: 3.0.0-alpha-1, 2.2.6, 2.3.2
• Component/s: Replication
• Assignee: Sun Xin
• Reporter: Guanghao Zhang
• Created: 12/Aug/20 06:52
• Updated: 25/Aug/20 00:35
• Resolved: 25/Aug/20 00:05

Description

See code in https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L519

 

The WAL enqueued to wrong replication source.

    for (String queueId : previousQueueIds) {
        ReplicationSourceInterface replicationSource = createSource(queueId, peer);
        this.oldsources.add(replicationSource);
        this.queueStorage.getWALsInQueue(this.server.getServerName(), queueId)
          .forEach(wal -> src.enqueueLog(new Path(wal)));
        toStartup.add(replicationSource);
      }

Issue Links

• links to: GitHub Pull Request #2249