Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24792

return value of LogRoller.walRollFinished may be wrong

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.0.0-alpha-1, 2.3.1, 2.2.6
    • 3.0.0-beta-2
    • None
    • None

    Description

      The LogRoller.walRollFinished impl is already buggy. This just checks the status of the boolean. Once we start a roll on a WAL, we reset the boolean (Even before patch HBASE-24665). So it is not clearly telling anything abt the roll status. This can return true even while an active wal roll is going on.

      We might need another boolean in Controller which clearly tracks whether we are ongoing a roll.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #2169

          Activity

            People

              Unassigned Unassigned
              wenfeiyi666 wenfeiyi666
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated: