[HBASE-24743] Reject to add a peer which replicate to itself earlier

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.4.0
• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 15/Jul/20 03:15
• Updated: 29/Oct/21 10:35
• Resolved: 24/Jul/20 00:11

Description

Now there are one check in ReplicationSource#initialize method

// In rare case, zookeeper setting may be messed up. That leads to the incorrect
// peerClusterId value, which is the same as the source clusterId
if (clusterId.equals(peerClusterId) && !replicationEndpoint.canReplicateToSameCluster()) {
  this.terminate("ClusterId " + clusterId + " is replicating to itself: peerClusterId "
      + peerClusterId + " which is not allowed by ReplicationEndpoint:"
      + replicationEndpoint.getClass().getName(), null, false);
  this.manager.removeSource(this);
  return;
}

This check should move to AddPeerProcedure's precheck.

Issue Links

• breaks: HBASE-26406 Can not add peer replicating to non-HBase
• links to: GitHub Pull Request #2071
• links to: GitHub Pull Request #2122
• links to: GitHub Pull Request #2124