Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24716

Do the error handling for replication admin failures

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Replication
    • Labels:
      None

      Description

      listPeerConfigs() for getting the list of peers along with their configuration is not a reliable API.

      It is not very robust to errors, logs FATAL and swallows the exceptions

       

      Snippet:

      catch (KeeperException e) {
       this.abortable.abort("Cannot get the list of peers ", e);
      } catch (ReplicationException e) {
       this.abortable.abort("Cannot get the list of peers ", e);
      }
      return peers;
      

       

      The abortable (connection in this case) also doesn't abort the region server and just logs. This makes upstream believe that there is nothing wrong and proceed without any action which is not good.

       

       

      2020-07-07 23:11:37,857 FATAL [14774961,peer_id] client.ConnectionManager$HConnectionImplementation - Cannot get the list of peersorg.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = Session expired for /hbase/replication/peersat org.apache.zookeeper.KeeperException.create(KeeperException.java:130)at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1549)at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getChildren(RecoverableZooKeeper.java:312)at org.apache.hadoop.hbase.zookeeper.ZKUtil.listChildrenNoWatch(ZKUtil.java:513)at org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.getAllPeerConfigs(ReplicationPeersZKImpl.java:249)at org.apache.hadoop.hbase.client.replication.ReplicationAdmin.listPeerConfigs(ReplicationAdmin.java:332)
      

       

       

        Attachments

          Activity

            People

            • Assignee:
              sandeep.pal Sandeep Pal
              Reporter:
              sandeep.pal Sandeep Pal
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: