Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24695

FSHLog - close the current WAL file in a background thread

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha-1, 2.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We have this as a TODO in code already

      // It is at the safe point. Swap out writer from under the blocked writer thread.
            // TODO: This is close is inline with critical section. Should happen in background?
            if (this.writer != null) {
              oldFileLen = this.writer.getLength();
              try {
                TraceUtil.addTimelineAnnotation("closing writer");
                this.writer.close();
                TraceUtil.addTimelineAnnotation("writer closed");
                this.closeErrorCount.set(0);
              }
      

      This close call in critical section and writes are blocked. Lets move this close call into another WALCloser thread.

        Attachments

          Activity

            People

            • Assignee:
              anoop.hbase Anoop Sam John
              Reporter:
              anoop.hbase Anoop Sam John
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: