What did you do to the patch J-D?
Mostly just a refresh, and I removed an now-unused boolean on sync().
In the hadoop we ship, we should include hdfs-895?
I think it would be great.
What should we do about group commit. Open a new issue?
We don't need it anymore, but having deferred log flush could still be useful. Should be in the same issue.
If hdfs-895 is not in place, we just run slower, is that right?
Yes, under concurrent writers it's much slower without 895.
If concurrency, should 'private boolean logRollRequested' be volatile?
As a matter of fact, it's under 2 different sync (this and updateLock). Maybe safer to put volatile?
Why not do the syncTime and syncOps under the updateLock rather than do a synchronize on 'this'?