Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24640

Purge use of VisibleForTesting

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha-1, 2.4.0
    • 3.0.0-alpha-1, 1.7.0, 2.4.0
    • community
    • None
    • Reviewed

    Description

      From the dev-list thread "[DISCUSS] VisibleForTesting annotation as it pertains to our API compatibility guidelines", when used in classes annotated with interface audience other than IA.Private, the VisibleForTesting annotation is confusing and considered harmful. The consensus is that we do not want to use this annotation as part of the definition of our public APIs, and we need to remove the point of confusion.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-25308 [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous

          • Major - Major loss of function.
          • Resolved
          relates to

          Task - A task that needs to be done. HBASE-25333 Add maven enforcer rule to ban VisibleForTesting imports

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. HBASE-25477 [filesystem] Purge use of VisibleForTesting

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #2695

          Web Link GitHub Pull Request #2696

          Web Link GitHub Pull Request #2697

          Activity

            People

              apurtell Andrew Kyle Purtell
              ndimiduk Nick Dimiduk
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: