Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24591

get_table_rsgroup ignored the existence of rsgroup config for namespace

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha-1
    • 3.0.0-alpha-1
    • rsgroup
    • None
    • Reviewed

    Description

      public GetRSGroupInfoOfTableResponse getRSGroupInfoOfTable(RpcController controller,
        GetRSGroupInfoOfTableRequest request) throws ServiceException {
        TableName tableName = ProtobufUtil.toTableName(request.getTableName());
        ...
        try {
          ...
          GetRSGroupInfoOfTableResponse resp;
          TableDescriptor td = master.getTableDescriptors().get(tableName);
          if (td == null) {
            resp = GetRSGroupInfoOfTableResponse.getDefaultInstance();
          } else {
            RSGroupInfo rsGroupInfo = null;
            if (td.getRegionServerGroup().isPresent()) {
              rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(td.getRegionServerGroup().get());
            }
            if (rsGroupInfo == null) {
              rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(RSGroupInfo.DEFAULT_GROUP);
            }
            resp = GetRSGroupInfoOfTableResponse.newBuilder()
              .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build();
          }
          ...
          return resp;
        } catch (IOException e) {
          throw new ServiceException(e);
        }
      }
      
      

      In method MasterRpcServices#getRSGroupInfoOfTable, ignored namespace hbase.rsgroup.name config. 
       
      It should be replaced by RSGroupUtil#getRSGroupInfo. 
       

      Attachments

        Issue Links

          Activity

            People

              Ddupg Sun Xin
              Ddupg Sun Xin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: