[HBASE-24581] Skip compaction request/check for replica regions at the early stage.

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.3.0
• Component/s: read replicas
• Assignee: Huaxiang Sun
• Reporter: Huaxiang Sun
• Created: 17/Jun/20 21:13
• Updated: 15/Jul/20 12:17

Description

I found that in certain cases replica regions can trigger compaction, one example as follows, need to check all places to avoid compaction for replica regions.

@Override
public void postOpenDeployTasks(final PostOpenDeployContext context) throws IOException {
  HRegion r = context.getRegion();
  long openProcId = context.getOpenProcId();
  long masterSystemTime = context.getMasterSystemTime();
  rpcServices.checkOpen();
  LOG.info("Post open deploy tasks for {}, openProcId={}, masterSystemTime={}",
    r.getRegionInfo().getRegionNameAsString(), openProcId, masterSystemTime);
  // Do checks to see if we need to compact (references or too many files)
  // TODO: SHX, do not do this for replica regions? Otherwise, it is going to lost data locality for primary regions.
  for (HStore s : r.stores.values()) {
    if (s.hasReferences() || s.needsCompaction()) {
      this.compactSplitThread.requestSystemCompaction(r, s, "Opening Region");
    }
  }
 

Issue Links

• Is contained by: HBASE-24554 Improve/stable read replica
• links to: GitHub Pull Request #1986