[HBASE-23832] Old config hbase.hstore.compactionThreshold is ignored

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.1.10, 2.2.5
• Hadoop Flags: Reviewed
• Assignee: Sambit Mohapatra
• Reporter: Anoop Sam John
• Created: 12/Feb/20 18:26
• Updated: 14/May/20 16:59
• Resolved: 14/May/20 16:59

Description

In 2.x we added new name 'hbase.hstore.compaction.min' for this. Still for compatibility we allow the old config name and honor that in code

minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY,
          /*old name*/ conf.getInt("hbase.hstore.compactionThreshold", 3)));

But if hbase.hstore.compactionThreshold alone is configured by user, there is no impact of that.

This is because in hbase-default.xml we have the new config with a value of 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a value 3 even if it is not explicitly configured by customer and instead used the old key.

Issue Links

• relates to: HBASE-24362 Remove/Retain deprecated configs
• links to: GitHub Pull Request #1674
• links to: GitHub Pull Request #1698 (target: branch-2)