[HBASE-23699] ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: rpc
• Assignee: chenxu
• Reporter: chenxu
• Created: 16/Jan/20 12:21
• Updated: 19/Jan/20 03:04

Description

Code in NettyRpcServerResponseEncoder

@Override
public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception {
  if (msg instanceof RpcResponse) {
    RpcResponse resp = (RpcResponse) msg;
    BufferChain buf = resp.getResponse();
    ctx.write(Unpooled.wrappedBuffer(buf.getBuffers()), promise).addListener(f -> {
      resp.done();
      if (f.isSuccess()) {
        metrics.sentBytes(buf.size());
      }
    });
  } else {
    ctx.write(msg, promise);
  }
}

If exception occurs during ChannelHandlerContext#write (such as Client disconnected), ByteBuff may not be recycled correctly.

Issue Links

• links to: GitHub Pull Request #1055