[HBASE-23658] Fix flaky TestSnapshotFromMaster

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
• Assignee: Guanghao Zhang
• Reporter: Guanghao Zhang
• Created: 08/Jan/20 00:57
• Updated: 17/Feb/20 20:37
• Resolved: 10/Jan/20 09:20

Description

testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may fail.

assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
future.get(); // in branch-2.2, here is Thread.sleep
assertFalse(master.getSnapshotManager().isTakingAnySnapshot());

See https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/

 

https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html

Issue Links

• relates to: HBASE-23862 Fix flaky TestSnapshotFromMaster in 1.x versions
• links to: GitHub Pull Request #998