[HBASE-23356] When construct StoreScanner throw exceptions it is possible to left some KeyValueScanner not closed.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
• Assignee: Lijin Bin
• Reporter: Lijin Bin
• Created: 03/Dec/19 03:03
• Updated: 05/Dec/19 03:33
• Resolved: 04/Dec/19 02:42

Description

    try {
      // Pass columns to try to filter out unnecessary StoreFiles.
      List<KeyValueScanner> scanners = selectScannersFrom(store,
        store.getScanners(cacheBlocks, scanUsePread, false, matcher, scan.getStartRow(),
          scan.includeStartRow(), scan.getStopRow(), scan.includeStopRow(), this.readPt));

      // Seek all scanners to the start of the Row (or if the exact matching row
      // key does not exist, then to the start of the next matching Row).
      // Always check bloom filter to optimize the top row seek for delete
      // family marker.
      seekScanners(scanners, matcher.getStartKey(), explicitColumnQuery && lazySeekEnabledGlobally,
        parallelSeekEnabled);
    
        ......
    } catch (IOException e) {
      // remove us from the HStore#changedReaderObservers here or we'll have no chance to
      // and might cause memory leak
      store.deleteChangedReaderObserver(this);
      throw e;
    }

Like the above, if the seekScanners(scanners,...) throws exception, the scanners do not closed, we need to close the scanners.

Issue Links

• links to: GitHub Pull Request #891