[HBASE-23345] Table need to replication unless all of cfs are excluded

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
• Component/s: Replication
• Flags: Patch
• Assignee: Sun Xin
• Reporter: Sun Xin
• Created: 26/Nov/19 11:18
• Updated: 03/Jan/20 14:32
• Resolved: 04/Dec/19 03:36

Description

There is duplicate code in ReplicationUtils.contains and ReplicationPeerConfig.needToReplicate about deciding whether a table need replicate to the peer cluster.
And the implementation of ReplicationPeerConfig.needToReplicate has a bug, it return false when replicateAllUserTables flag is true and excludeTableCFsMap contains not all of cfs.
 
We should copy the code from ReplicationUtils.contains to ReplicationPeerConfig.needToReplicate, and delete ReplicationUtils.contains.Because ReplicationUtils is from module replication, ReplicationPeerConfig is from module client, and module replication depends on module client.
 
In the following code, ReplicationPeerConfig.needToReplicate return false, when replicateAllUserTables flag is true and excludeTableCFsMap contains not all of cfs.

public boolean needToReplicate(TableName table) {
  if (replicateAllUserTables) {
  ......
    if (excludeTableCFsMap != null && excludeTableCFsMap.containsKey(table)) {
      return false;
    }
  ......
}

Issue Links

• breaks: HBASE-23641 Use ReplicationPeerConfig.needToReplicate in HBaseFsck
• relates to: HBASE-23642 Reintroduce ReplicationUtils.contains as deprecated
• links to: GitHub Pull Request #881
• links to: Review Board (branch-2)