Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23172

HBase Canary region success count metrics reflect column family successes, not region successes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0-alpha-1, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1
    • 3.0.0-alpha-1, 2.3.0, 1.6.0, 2.1.8, 2.2.3
    • canary
    • None
    • Reviewed
    • Hide
      Added a comment to make clear that read/write success counts are tallying column family success counts, not region success counts.

      Additionally, the region read and write latencies previously only stored the latencies of the last column family of the region reads/writes. This has been fixed by using a map of each region to a list of read and write latency values.
      Show
      Added a comment to make clear that read/write success counts are tallying column family success counts, not region success counts. Additionally, the region read and write latencies previously only stored the latencies of the last column family of the region reads/writes. This has been fixed by using a map of each region to a list of read and write latency values.

    Description

      HBase Canary reads once per column family per region. The current "region success count" should actually be "column family success count," which means we need another metric that actually reflects region success count. Additionally, the region read and write latencies only store the latencies of the last column family of the region read. Instead of a map of regions to a single latency value and success value, we should map each region to a list of such values.

      Attachments

        1. HBASE-23172.branch-1.000.patch
          10 kB
          Caroline Zhou
        2. HBASE-23172.branch-2.000.patch
          10 kB
          Caroline Zhou
        3. HBASE-23172.master.000.patch
          10 kB
          Michael Stack
        4. HBASE-23172.master.000.patch
          10 kB
          Caroline Zhou
        5. HBASE-23172.master.000.patch
          10 kB
          Caroline Zhou

        Activity

          People

            caroliney14 Caroline Zhou
            caroliney14 Caroline Zhou
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: