[HBASE-23115] Unit change for StoreFileSize and MemStoreSize

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.2, 2.1.8
• Component/s: metrics, UI
• Assignee: Karthik Palanisamy
• Reporter: Karthik Palanisamy
• Created: 02/Oct/19 22:24
• Updated: 12/Oct/19 04:18
• Resolved: 11/Oct/19 14:10

Description

StoreFileSize and MemstoreSize usually returned in MBs (link1, link2)  but few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on length. The concern here (link4) is computation (ByteVal/1024/1024) will output always lesser than 1 for store contains few bytes or few kbs.  Also, typecast will not round up to its nearest value.

I think the best option is changing unit in table.jsp instead of changing code, otherwise we may end up doing many refactors from getMemStoreSizeMB, setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB, setStorefileSizeMB,..

 

Please find the attachment, a simple example is posted.

Issue Links

• links to: GitHub Pull Request #682
• links to: GitHub Pull Request #710