[HBASE-23093] Avoid Optional Anti-Pattern where possible

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.3.0, 1.6.0
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.2, 2.1.8
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 29/Sep/19 10:13
• Updated: 16/Oct/19 10:28
• Resolved: 16/Oct/19 10:28

Description

Optional should be used as a return type only. It's a neat solution for handling data that might  not be present. We should avoid using Optional Anti-Patterns i.e. using it as a field or parameter type due to these reasons:

1. Using Optional parameters causing conditional logic inside the methods is not productive.

2. Packing an argument in an Optional is suboptimal for the compiler and does an unnecessary wrapping.

3. Optional field is not serializable.

Issue Links

• is a parent of: HBASE-23127 Compile rule to avoid Optional<> params as argument of method
• links to: GitHub Pull Request #673