[HBASE-23051] Remove unneeded Mockito.mock invocations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.3.0, 2.1.7, 2.2.2
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.1.7, 2.2.2
• Component/s: test
• Hadoop Flags: Reviewed
• Assignee: Peter Somogyi Assign to me
• Reporter: Peter Somogyi
• Created: 19/Sep/19 06:47
• Updated: 20/Sep/19 10:12
• Resolved: 20/Sep/19 04:04

Description

ErrorProne fails the build using the new Mockito version.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project hbase-server: Compilation failure: Compilation failure: 
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/component/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java:[147,16] error: [CheckReturnValue] Ignored return value of method that is annotated with @CheckReturnValue
[ERROR]     (see https://errorprone.info/bugpattern/CheckReturnValue)
[ERROR]   Did you mean to remove this line?
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/component/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/TestZKProcedureControllers.java:[331,16] error: [CheckReturnValue] Ignored return value of method that is annotated with @CheckReturnValue
[ERROR]     (see https://errorprone.info/bugpattern/CheckReturnValue)
[ERROR]   Did you mean to remove this line?
[ERROR] -> [Help 1] 

https://builds.apache.org/job/HBase%20Nightly/job/master/1456/artifact/output-jdk8-hadoop2/patch-compile-root.txt

Issue Links

• links to: GitHub Pull Request #641