[HBASE-22937] The RawBytesComparator in branch-1 have wrong comparison order

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0, 1.3.6, 1.4.11
• Hadoop Flags: Reviewed
• Assignee: Zheng Hu
• Reporter: Zheng Hu
• Created: 28/Aug/19 04:00
• Updated: 05/Sep/19 23:58
• Resolved: 05/Sep/19 11:25

Description

When digging the HBASE-22862, we found a bug in RawBytesComparator#compareOnlyKeyPortion (although it's unrelated to the corruption in HBASE-22862).

    @Override
    @VisibleForTesting
    public int compareOnlyKeyPortion(Cell left, Cell right) {
        // ...
      return (0xff & left.getTypeByte()) - (0xff & right.getTypeByte());
    }

Here should be (0xff & right.getTypeByte()) - (0xff & left.getTypeByte()) I think.

I can see the BloomFilter or HFile v2 are still using the comparator in branch-1 (but not in branch-2). Maybe we can just remove the class (if some HFile encoded with this comparator, then mapping to the correct KVComparator just like 2.x), or fix the bug in current RawBytesComparator.

Issue Links

• links to: GitHub Pull Request #582