Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22936

Close memStoreScanners in StoreScanner#updateReaders else memory leak

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 2.3.0, 2.1.7, 2.2.2
    • Component/s: None
    • Labels:
      None

      Description

      Via [~aoxiang] from over on HBASE-22723

      +      if (!closeLock.tryLock()) {
      +        // no lock acquired.
      +        LOG.debug("StoreScanner already has the close lokc. There is no need to updateReaders");
      +        return;
      +      }
      +      // lock acquired
      +      updateReaders = true;
      +      if (this.closing) {
      +        LOG.debug("StoreScanner already closing. There is no need to updateReaders");
      +        return;
      +      }
      

      We need to close memStoreScanners in StoreScanner#updateReaders before this two return, someone else can take over the task.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                stack Michael Stack
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: