Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22926

REST server should return 504 Gateway Timeout Error on scanner timeout

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0, 2.1.0, 2.2.0
    • Fix Version/s: None
    • Component/s: REST
    • Labels:
      None

      Description

      Currently when a scanner timeout error occurs on the RS side, a client will get a RetriesExhaustedException that will make the client to fail, however from the REST server point of view that is just an IOE:

      org.apache.hadoop.hbase.rest.ScannerResultGenerator#next

      } else {
              Result result = null;
              try {
                result = scanner.next();
              } catch (UnknownScannerException e) {
                throw new IllegalArgumentException(e);
              } catch (TableNotEnabledException tnee) {
                throw new IllegalStateException(tnee);
              } catch (TableNotFoundException tnfe) {
                throw new IllegalArgumentException(tnfe);
              } catch (IOException e) {
                LOG.error(StringUtils.stringifyException(e));
              }
      

      Now, with that empty result (will handle this as an HTTP 204 response back to the client:

      org.apache.hadoop.hbase.rest.ScannerInstanceResource#get

      ...
        Cell value = null;
            try {
              value = generator.next();
            } catch (IllegalStateException e) {
      ...
            } catch (IllegalArgumentException e) {
      ...
            }
      ...
      if (value == null) {
              if (LOG.isTraceEnabled()) {
                LOG.trace("generator exhausted");
              }
              // respond with 204 (No Content) if an empty cell set would be
              // returned
              if (count == limit) {
                return Response.noContent().build();
              }
              break;
      

      Obviously this is wrong, since a RetriesExhaustedException is most likely due a failure in the RS side. The correct behavior should be a 504 Gateway Timeout Error.

        Attachments

          Activity

            People

            • Assignee:
              esteban Esteban Gutierrez
              Reporter:
              esteban Esteban Gutierrez
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: