[HBASE-22508] Address findbugs/spotbugs complaints (branch-1.3)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.5
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 30/May/19 17:47
• Updated: 01/Jun/19 02:59
• Resolved: 01/Jun/19 00:18

Description

FindBugs module:hbase-hadoop2-compat
java.util.concurrent.ScheduledThreadPoolExecutor stored into non-transient field MetricsExecutorImpl$ExecutorSingleton.scheduler At MetricsExecutorImpl.java:MetricsExecutorImpl$ExecutorSingleton.scheduler At MetricsExecutorImpl.java:[line 51]
FindBugs module:hbase-server
Possible null pointer dereference of walKey in org.apache.hadoop.hbase.regionserver.HRegion.append(Append, long, long) Dereferenced at HRegion.java:walKey in org.apache.hadoop.hbase.regionserver.HRegion.append(Append, long, long) Dereferenced at HRegion.java:[line 7815]
Possible null pointer dereference of walKey in org.apache.hadoop.hbase.regionserver.HRegion.doIncrement(Increment, long, long) Dereferenced at HRegion.java:walKey in org.apache.hadoop.hbase.regionserver.HRegion.doIncrement(Increment, long, long) Dereferenced at HRegion.java:[line 8052]
Possible null pointer dereference of r in org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection) Dereferenced at HStore.java:r in org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection) Dereferenced at HStore.java:[line 2810]
org.apache.hadoop.hbase.tool.Canary$RegionMonitor.run() makes inefficient use of keySet iterator instead of entrySet iterator At Canary.java:keySet iterator instead of entrySet iterator At Canary.java:[line 1095]

Issue Links

• links to: GitHub Pull Request #275
• links to: GitHub Pull Request #276