[HBASE-22476] HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0, 2.1.4
• Fix Version/s: 3.0.0-alpha-1
• Component/s: backup&restore
• Assignee: lixiaobao
• Reporter: lixiaobao
• Created: 27/May/19 00:31
• Updated: 16/Nov/20 10:49
• Resolved: 16/Nov/20 10:49

Description

class "org.apache.hadoop.hbase.backup.impl.BackupManifest" constructe function

public BackupManifest(FileSystem fs, Path backupPath) throws BackupException {...} 

FSDataInputStream is not close after use.

//代码占位符
if (subFile.getPath().getName().equals(MANIFEST_FILE_NAME)) {
  // load and set manifest field from file content
  FSDataInputStream in = fs.open(subFile.getPath());
  long len = subFile.getLen();
  byte[] pbBytes = new byte[(int) len];
  in.readFully(pbBytes);
  BackupProtos.BackupImage proto = null;
  try {
    proto = BackupProtos.BackupImage.parseFrom(pbBytes);
  } catch (Exception e) {
    throw new BackupException(e);
  }
  this.backupImage = BackupImage.fromProto(proto);
  LOG.debug("Loaded manifest instance from manifest file: "
      + BackupUtils.getPath(subFile.getPath()));
  return;
}

Issue Links

• links to: GitHub Pull Request #263