Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22119

Provide functions in RSGroupInfo to check if a group is the default group

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: rsgroup
    • Labels:
      None

      Description

      There are several places to check if a group is the "default" group, where the input could be a String or a RSGroupInfo.
      It is better to provide official functions in RSGroupInfo to tell if a group is the default group, so as to

      • Simply the code
      • Make it more safe. It is not safe as there is no null check like
        if (!group.getName().equals(RSGroupInfo.DEFAULT_GROUP))
        

        It is more safe to check like:

        RSGroupInfo.DEFAULT_GROUP.equals(group.getName())
        

        Attachments

        1. HBASE-22119.branch-1.000.patch
          6 kB
          Xiang Li
        2. HBASE-22119.master.000.patch
          7 kB
          Xiang Li

          Activity

            People

            • Assignee:
              water Xiang Li
              Reporter:
              water Xiang Li
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: