[HBASE-22051] Expect values are hard-coded in the verifications of TestRSGroupsBasics

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 1.5.0, 2.3.0
• Component/s: rsgroup, test
• Assignee: Xiang Li
• Reporter: Xiang Li
• Created: 14/Mar/19 13:08
• Updated: 07/Apr/20 20:48
• Resolved: 22/Mar/19 07:00

Description

In TestRSGroupsBase, we have NUM_SLAVES_BASE = 4, which is used to launch the mini cluster. But in some verifications of TestGroupsBasics, such as in testBasicStartUp(), the expected value is hard-coded as 4, like:

public void testBasicStartUp() throws IOException {
  ...
  assertEquals(4, defaultInfo.getServers().size());
  ..
}

We could also some other places which have hard-coded verifications, as follow:

public void testClearDeadServers() throws Exception {
  ...
  final RSGroupInfo newGroup = addGroup(getGroupName(name.getMethodName()), 3);
  ...
  assertEquals(2, newGroupServers.size());

and

public void testClearNotProcessedDeadServer() throws Exception {
  ...
  RSGroupInfo appInfo = addGroup("deadServerGroup", 1);
  ...
  assertEquals(1, notClearedServers.size());