Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-22051

Expect values are hard-coded in the verifications of TestRSGroupsBasics

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0, 1.5.0, 2.3.0
    • Component/s: rsgroup, test
    • Labels:
      None

      Description

      In TestRSGroupsBase, we have NUM_SLAVES_BASE = 4, which is used to launch the mini cluster. But in some verifications of TestGroupsBasics, such as in testBasicStartUp(), the expected value is hard-coded as 4, like:

      public void testBasicStartUp() throws IOException {
        ...
        assertEquals(4, defaultInfo.getServers().size());
        ..
      }
      

      We could also some other places which have hard-coded verifications, as follow:

      public void testClearDeadServers() throws Exception {
        ...
        final RSGroupInfo newGroup = addGroup(getGroupName(name.getMethodName()), 3);
        ...
        assertEquals(2, newGroupServers.size());
      

      and

      public void testClearNotProcessedDeadServer() throws Exception {
        ...
        RSGroupInfo appInfo = addGroup("deadServerGroup", 1);
        ...
        assertEquals(1, notClearedServers.size());
      

        Attachments

        1. HBASE-22051.branch-2.000.patch
          6 kB
          Xiang Li
        2. HBASE-22051.branch-1.000.patch
          5 kB
          Xiang Li
        3. HBASE-22051.master.000.patch
          6 kB
          Xiang Li

          Activity

            People

            • Assignee:
              water Xiang Li
              Reporter:
              water Xiang Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: