[HBASE-21943] The usage of RegionLocations.mergeRegionLocations is wrong for async client

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.0.5, 2.3.0, 2.1.4
• Component/s: asyncclient, Client
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 21/Feb/19 10:56
• Updated: 27/Feb/19 10:22
• Resolved: 27/Feb/19 03:20

Description

In AsyncRegionLocatorHelper.mergeRegionLocations we create a new RegionLocations and call mergeRegionLocations on it, expected that it will be changed by this method, but actually the method will not modify the object itself, it will return a new one...

And we are lucky that we create the RegionLocations with the new locations, so usually we will get update result. But when testing HBASE-21717, we meet another bug in AsyncNonMetaRegionLocator.isEqual, where we missed a '!' when checking server name equals...