Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20188 Evaluate and address performance delta between branch-1 and branch-2
  3. HBASE-21750

Most of KeyValueUtil#length can be replaced by cell#getSerializedSize for better performance because the latter one has been optimized

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.2.0
    • None
    • None
    • Reviewed

    Description

      After HBASE-21657, Most subclass of Cell has a cached serialized size (Except those cells with tags), so I think most of the KeyValueUtil#length can be replaced by cell#getSerializedSize. Such as:

      • KeyValueUtil.length in StoreFlusher#performFlush;
      • KeyValueUtil.length in Compactor#performCompaction ;

      and so on..

      Will prepare a patch for this.

      Attachments

        1. HBASE-21750.v1.patch
          23 kB
          Zheng Hu
        2. HBASE-21750.v1.patch
          23 kB
          Michael Stack
        3. HBASE-21750.v2.patch
          26 kB
          Zheng Hu
        4. HBASE-21750.v3.patch
          32 kB
          Zheng Hu
        5. HBASE-21750.v3.patch
          32 kB
          Zheng Hu

        Issue Links

          Activity

            People

              openinx Zheng Hu
              openinx Zheng Hu
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: