[HBASE-21732] Should call toUpperCase before using Enum.valueOf in some methods for ColumnFamilyDescriptor

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.3, 2.0.5
• Component/s: Client
• Hadoop Flags: Reviewed
• Release Note: Now all the Enum configs in ColumnFamilyDescriptor can accept lower case config value.
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 16/Jan/19 09:36
• Updated: 16/Jan/19 19:46
• Resolved: 16/Jan/19 12:57

Description

When upgrading we faced a problem that the some regions can not be opened due to the region server can not recognize the lower case 'snappy' config. In code for branch-1, we have done this

  public Compression.Algorithm getCompression() {
    String n = getValue(COMPRESSION);
    if (n == null) {
      return Compression.Algorithm.NONE;
    }
    return Compression.Algorithm.valueOf(n.toUpperCase(Locale.ROOT));
  }

But in the code of 2.0+, we just call valueOf.

Issue Links

• is broken by: HBASE-18008 Any HColumnDescriptor we give out should be immutable