Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20951 Ratis LogService backed WALs
  3. HBASE-21456

Make WALFactory only used for creating WALProviders

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: HBASE-20952
    • Fix Version/s: HBASE-20952
    • Component/s: wal
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As a Factory, WALFactory should only have one job: creating instances of WALProvider.

      However, over the years, it has been a landing place for lots of wal-related methods (e.g. constructing readers, WALEntryStream, and more). We want all of this to live in the WALProvider.

      We can do this in two steps: have the WALFactory methods invoke the method on the WALProvider (handled elsewhere), then here we can replace usage of the WALFactory "wrapper methods" with the WALProvider itself.

        Attachments

        1. HBASE-21456.HBASE-20952.001.patch
          178 kB
          Ankit Singhal
        2. HBASE-21456.HBASE-20952.002.patch
          179 kB
          Ankit Singhal
        3. HBASE-21456.HBASE-20952.003.patch
          190 kB
          Ankit Singhal
        4. HBASE-21456.HBASE-20952.wip.patch
          77 kB
          Ankit Singhal

          Activity

            People

            • Assignee:
              ankit@apache.org Ankit Singhal
              Reporter:
              elserj Josh Elser
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: