[HBASE-21357] RS should abort if OOM in Reader thread

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.4.8
• Fix Version/s: 1.3.3, 1.4.9, 1.2.9
• Component/s: regionserver
• Assignee: Allan Yang
• Reporter: Allan Yang
• Created: 22/Oct/18 08:24
• Updated: 01/Feb/19 20:13
• Resolved: 24/Oct/18 03:14

Description

It is a bit strange, we will abort the RS if OOM in Listener thread, Responder thread and in CallRunner thread, only not in Reader thread...
We should abort RS if OOM happens in Reader thread, too. If not, the reader thread exists because of OOM, and the selector closes. Later connection select to this reader will be ignored

try {
              if (key.isValid()) {
                if (key.isAcceptable())
                  doAccept(key);
              }
            } catch (IOException ignored) {
              if (LOG.isTraceEnabled()) LOG.trace("ignored", ignored);
            }

Leaving the client (or Master and other RS)'s call wait until SocketTimeout.