Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-20828 Finish-up AMv2 Design/List of Tenets/Specification of operation
  3. HBASE-21354

Procedure may be deleted improperly during master restarts resulting in 'Corrupt'

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0, 2.0.2
    • Fix Version/s: 3.0.0, 2.2.0, 2.1.1, 2.0.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Good news! Michael Stack, [~Apache9], I may find the root cause of mysterious ‘Corrupted procedure’ or some procedures disappeared after master restarts(happens during ITBLL).
      This is because during master restarts, we load procedures from the log, and builds the 'holdingCleanupTracker' according each log's tracker. We may mark a procedure in the oldest log as deleted if one log doesn't contain the procedure. This is Inappropriate since one log will not contain info of the log if this procedure was not updated during the time. We can only delete the procedure only if it is not in the global tracker, which have the whole picture.

      trackerNode = tracker.lookupClosestNode(trackerNode, procId);
              if (trackerNode == null || !trackerNode.contains(procId) ||
                trackerNode.isModified(procId)) {
                // the procedure was removed or modified
                node.delete(procId);
              }
      

      A test case(testProcedureShouldNotCleanOnLoad) shows cleanly how the corruption happened in the patch.

        Attachments

        1. HBASE-21354-addendum.patch
          2 kB
          Duo Zhang
        2. HBASE-21354.branch-2.0.004.patch
          23 kB
          Allan Yang
        3. HBASE-21354.branch-2.0.003.patch
          22 kB
          Allan Yang
        4. HBASE-21354.branch-2.0.002.patch
          22 kB
          Allan Yang
        5. HBASE-21354.branch-2.0.001.patch
          20 kB
          Allan Yang

          Issue Links

            Activity

              People

              • Assignee:
                allan163 Allan Yang
                Reporter:
                allan163 Allan Yang
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: