Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21255

[acl] Refactor TablePermission into three classes (Global, Namespace, Table)

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      A TODO in TablePermission.java

        //TODO refactor this class
  //we need to refacting this into three classes (Global, Table, Namespace)

      Change Notes:

      • Divide origin TablePermission into three classes GlobalPermission, NamespacePermission, TablePermission
      • New UserPermission consists of a user name(string, not byte[], for convenience) and a permission in one of [Global, Namespace, Table]Permission.
      • Rename TableAuthManager to AuthManager(it is IA.P), and rename some methods for readability.
      • Make PermissionCache thread safe, and the ListMultiMap is changed to Set.
      • User cache and group cache in AuthManager is combined together.
      • Wire proto is kept, BC should be under guarantee.
      • Fix HBASE-21390.
      • Resolve a small TODO global entry should be handled differently in AccessControlLists
      • Add a new api in Permission#getAccessScope()

      Attachments

        1. HBASE-21255.master.006.patch
          212 kB
          Reid Chan
        2. HBASE-21255.master.006.patch
          212 kB
          Michael Stack
        3. HBASE-21255.master.005.patch
          212 kB
          Reid Chan
        4. HBASE-21255.master.004.patch
          211 kB
          Reid Chan
        5. HBASE-21255.master.003.patch
          212 kB
          Reid Chan
        6. HBASE-21225.master.009.patch
          205 kB
          Reid Chan
        7. HBASE-21225.master.009.patch
          205 kB
          Reid Chan
        8. HBASE-21225.master.008.patch
          212 kB
          Reid Chan
        9. HBASE-21225.master.007.patch
          212 kB
          Reid Chan
        10. HBASE-21225.master.002.patch
          203 kB
          Reid Chan
        11. HBASE-21225.master.001.patch
          188 kB
          Reid Chan

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. HBASE-22503 Failed to upgrade to 2.2+ as the global permission which storaged in zk is not right

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved

          Umbrella - An overarching type made of sub-tasks HBASE-21489 TestShell is broken

          • Major - Major loss of function.
          • Resolved
          contains

          Sub-task - The sub-task of the issue HBASE-19698 Use CHM instead of CLSM in TableAuthManager

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-21390 [test] TestRpcAccessChecks is buggy

          • Major - Major loss of function.
          • Resolved
          relates to

          Sub-task - The sub-task of the issue HBASE-21677 Port (HBASE-21255 [acl] Refactor TablePermission into three classes) to branch-1

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link review board

          Activity

            People

              reidchan Reid Chan
              reidchan Reid Chan
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: