[HBASE-21225] Having RPC & Space quota on a table/Namespace doesn't allow space quota to be removed using 'NONE'

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.3, 2.0.5
• Labels: quota space
• Hadoop Flags: Reviewed
• Assignee: Sakthi
• Reporter: Sakthi
• Created: 25/Sep/18 06:36
• Updated: 22/Apr/19 02:28
• Resolved: 15/Jan/19 01:04

Description

A part of HBASE-20705 is still unresolved. In that Jira it was assumed that problem is: when table having both rpc & space quotas is dropped (with hbase.quota.remove.on.table.delete set as true), the rpc quota is not set to be dropped along with table-drops, and space quota was not being able to be removed completely because of the "EMPTY" row that rpc quota left even after removing. 

The proposed solution for that was to make sure that rpc quota didn't leave empty rows after removal of quota. And setting automatic removal of rpc quota with table drops. That made sure that space quotas can be recreated/removed.

But all this was under the assumption that hbase.quota.remove.on.table.delete is set as true. When it is set as false, the same issue can reproduced. Also the below shown steps can used to reproduce the issue without table-drops.

hbase(main):005:0> create 't2','cf'
Created table t2
Took 0.7619 seconds
=> Hbase::Table - t2
hbase(main):006:0> set_quota TYPE => THROTTLE, TABLE => 't2', LIMIT => '10M/sec'
Took 0.0514 seconds
hbase(main):007:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '1G', POLICY => NO_WRITES
Took 0.0162 seconds
hbase(main):008:0> list_quotas
OWNER                      QUOTAS
 TABLE => t2               TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT => 10M/sec, SCOPE =>
                           MACHINE
 TABLE => t2               TYPE => SPACE, TABLE => t2, LIMIT => 1073741824, VIOLATION_POLICY => NO_WRIT
                           ES
2 row(s)
Took 0.0716 seconds
hbase(main):009:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => NONE
Took 0.0082 seconds
hbase(main):010:0> list_quotas
OWNER                           QUOTAS
 TABLE => t2                    TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT => 10M/sec, SCOPE => MACHINE
 TABLE => t2                    TYPE => SPACE, TABLE => t2, REMOVE => true
2 row(s)
Took 0.0254 seconds
hbase(main):011:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '1G', POLICY => NO_WRITES
Took 0.0082 seconds
hbase(main):012:0> list_quotas
OWNER                           QUOTAS
 TABLE => t2                    TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT => 10M/sec, SCOPE => MACHINE
 TABLE => t2                    TYPE => SPACE, TABLE => t2, REMOVE => true
2 row(s)
Took 0.0411 seconds

Issue Links

• duplicates: HBASE-21807 Backport HBASE-21225 to branch-2.0 and branch-2.1
• is duplicated by: HBASE-21608 Having RPC quota, Not completely deleted SPACE quota
• is related to: HBASE-20705 Having RPC Quota on a table prevents Space quota to be recreated/removed
• links to: Review Board