[HBASE-21175] Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving

• Type: Test
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1
• Labels: snapshot
• Hadoop Flags: Reviewed
• Assignee: Artem Ervits
• Reporter: Ted Yu
• Created: 10/Sep/18 00:53
• Updated: 23/Apr/19 11:51
• Resolved: 26/Oct/18 23:45

Description

TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the test.
When SnapshotHFileCleaner.init() is called, there is no master parameter passed in params.

When the chore runs the cleaner during the test, NPE comes out of this line in getDeletableFiles():

      return cache.getUnreferencedFiles(files, master.getSnapshotManager());

since master is null.

We should either check for the null master or, pass master instance properly when constructing the cleaner instance.