[HBASE-21174] [REST] Failed to parse empty qualifier in TableResource#getScanResource

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.2.0
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 1.4.8, 2.1.1, 2.0.3
• Component/s: REST
• Assignee: Guangxu Cheng
• Reporter: Guangxu Cheng
• Created: 09/Sep/18 09:50
• Updated: 01/Feb/19 20:12
• Resolved: 12/Sep/18 16:01

Description

GET /t1/*?column=f:c1&column=f:

If I want to get the values of 'f:'(empty qualifier) for all rows in the table by rest server, I will send the above request. However, this request will return all column values.

TableResource#getScanResource

      for (String csplit : column) {
        String[] familysplit = csplit.trim().split(":");
        if (familysplit.length == 2) {
          if (familysplit[1].length() > 0) {
            if (LOG.isTraceEnabled()) {
              LOG.trace("Scan family and column : " + familysplit[0] + "  " + familysplit[1]);
            }
            tableScan.addColumn(Bytes.toBytes(familysplit[0]), Bytes.toBytes(familysplit[1]));
          } else {
            tableScan.addFamily(Bytes.toBytes(familysplit[0]));
            if (LOG.isTraceEnabled()) {
              LOG.trace("Scan family : " + familysplit[0] + " and empty qualifier.");
            }
            tableScan.addColumn(Bytes.toBytes(familysplit[0]), null);
          }
        } else if (StringUtils.isNotEmpty(familysplit[0])) {
          if (LOG.isTraceEnabled()) {
            LOG.trace("Scan family : " + familysplit[0]);
          }
          tableScan.addFamily(Bytes.toBytes(familysplit[0]));
        }
      }

Through the above code, when the column has an empty qualifier, the empty qualifier cannot be parsed correctly.In other words, 'f:'(empty qualifier) and 'f' (column family) are considered to have the same meaning, which is wrong.

Issue Links

• is blocked by: HBASE-21158 Empty qualifier cell should not be returned if it does not match QualifierFilter