[HBASE-21080] Collectors.toMap uses a byte [] for key

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 21/Aug/18 05:21
• Updated: 21/Aug/18 06:33
• Resolved: 21/Aug/18 05:22

Description

Good one found by a jxray spelunking Misha Dmitriev.

The below added by HBASE-19496 is making hashmaps with byte []s for keys (byte []'s don't do hashCode/Equals; usually when we have byte []'s for keys, we do ConcurrentMap and pass a Comparator in constructor that knows how to do byte []s).

.setStoreSequenceIds(regionLoadPB.getStoreCompleteSequenceIdList().stream()
  .collect(Collectors.toMap(
    (ClusterStatusProtos.StoreSequenceId s) -> s.getFamilyName().toByteArray(),
      ClusterStatusProtos.StoreSequenceId::getSequenceId)))

Issue Links

• is duplicated by: HBASE-21081 Trim Master memory usage, part 2