[HBASE-21071] HBaseTestingUtility::startMiniCluster() to use builder pattern

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.2.0
• Fix Version/s: 3.0.0-alpha-1, 2.2.0
• Component/s: test
• Labels: reviewed
• Hadoop Flags: Reviewed
• Release Note: Cleanup all the cluster start override combos in HBaseTestingUtility by adding a StartMiniClusterOption and Builder.
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 17/Aug/18 23:37
• Updated: 28/Aug/18 06:26
• Resolved: 27/Aug/18 17:24

Description

Currently there are 13 startMiniCluster() methods to set up a mini cluster. I'm not surprised if we have a few more in future. It's good to support different combination of optional parameters. We have to pick up one of them carefully while still wondering the default values of other parameters; if we add a new option, we may bring more new methods.

One solution is to use builder pattern: create a class MiniClusterOptions along with a static class MiniClusterOptionsBuilder, create a new method startMiniCluster(MiniClusterOptions). In master we delete the old 13 methods while in branch-2, we deprecate the old 13 methods.

Thoughts?

Issue Links

• links to: Review board #68424