[HBASE-21062] WALFactory has misleading notion of "default"

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.2.0, 2.1.1, 2.0.2
• Component/s: wal
• Hadoop Flags: Reviewed
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 15/Aug/18 19:03
• Updated: 18/Aug/18 00:13
• Resolved: 17/Aug/18 19:04

Description

In WALFactory, there is an enum Providers which has a list of supported WALProvider implementations. In addition to list this, there is also a defaultProvider (which the Configuration defaults to), that is meant to be our "advertised" default WALProvider.

However, the implementation of getProviderClass in WALFactory doesn't actually adhere to the value of this enum, instead always returning AsyncFSWal if it can be loaded.

Having the default value in the enum but then overriding it in the implementation of getProviderClass is silly and misleading.

Issue Links

• is caused by: HBASE-20839 Fallback to FSHLog if we can not instantiated AsyncFSWAL when user does not specify AsyncFSWAL explicitly