Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-21011

Provide CLI option to run oldwals and hfiles cleaner separately when cleaner chore is disabled

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 3.0.0, 1.4.6, 2.1.1
    • Fix Version/s: None
    • Component/s: Admin, Client
    • Labels:
      None

      Description

      There is a corner case when cleaner chore for HFiles and oldwals is disabled, admin/user needs to manually execute admin command cleaner_chore_run to clean the old HFiles and oldwals. Existing logic of cleaner_chore_run is to firstly trigger the HFiles cleaner and then oldwals cleaner, and only return succeed if both completes. 

      but when running this cleaner_chore_run command, there is a potential use case that admin would like trigger the cleaner for only oldwals or hfiles but still keep the automatic cleaner chore disabled. So, this change aims to provide support for this corner case, and provide flexibility for those user with cleaner chore disabled by default to execute admin CLI to run oldwals and HFiles cleaning procedure individually.

      NOTE that cleaner_chore_run was introduced in HBASE-17280, this patch added options 'hfiles' and 'oldwals' to it. Also fix default behavior of cleaner_chore_run will be only ran when cleaner chore is set to disabled, e.g. the proposed admin CLI options are

      hbase> cleaner_chore_run               # this was introduced in HBASE-17280, but changed the behavior to only ran when cleaner chore is set to disabled
      
      hbase> cleaner_chore_run 'hfiles'      # added, ran when cleaner chore is set to disabled
      hbase> cleaner_chore_run 'oldwals'     # added, ran when cleaner chore is set to disabled
      

        Attachments

        1. HBASE-21011.master.001.patch
          17 kB
          Tak-Lon (Stephen) Wu
        2. HBASE-21011.master.002.patch
          17 kB
          Tak-Lon (Stephen) Wu
        3. HBASE-21011.master.003.patch
          17 kB
          Tak-Lon (Stephen) Wu
        4. HBASE-21011.master.004.patch
          17 kB
          Tak-Lon (Stephen) Wu

          Issue Links

            Activity

              People

              • Assignee:
                taklwu Tak-Lon (Stephen) Wu
                Reporter:
                taklwu Tak-Lon (Stephen) Wu
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: