[HBASE-21000] Default limits for PressureAwareCompactionThroughputController are too low

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Component/s: Compaction
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 03/Aug/18 01:08
• Updated: 03/May/19 21:36
• Resolved: 10/Oct/18 01:56

Description

In PressureAwareCompactionThroughputController:

/**                                                                                                                                                                                 
 * A throughput controller which uses the follow schema to limit throughput                                                                                                         
 * <ul>                                                                                                                                                                             
 * <li>If compaction pressure is greater than 1.0, no limitation.</li>                                                                                                              
 * <li>In off peak hours, use a fixed throughput limitation                                                                                                                         
 * {@value #HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_OFFPEAK}</li>                                                                                                                    
 * <li>In normal hours, the max throughput is tuned between                                                                                                                         
 * {@value #HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_LOWER_BOUND} and                                                                                                                 
 * {@value #HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_HIGHER_BOUND}, using the formula &quot;lower +                                                                                   
 * (higher - lower) * compactionPressure&quot;, where compactionPressure is in range [0.0, 1.0]</li>                                                                                 
 * </ul>                                                                                                                                                                            
 */

The lower and upper bounds are 10MB/sec and 20MB/sec, respectively:

  public static final String HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_HIGHER_BOUND =
      "hbase.hstore.compaction.throughput.higher.bound";

  private static final long DEFAULT_HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_HIGHER_BOUND =
      20L * 1024 * 1024;

  public static final String HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_LOWER_BOUND =
      "hbase.hstore.compaction.throughput.lower.bound";

  private static final long DEFAULT_HBASE_HSTORE_COMPACTION_MAX_THROUGHPUT_LOWER_BOUND =
      10L * 1024 * 1024;

(In contrast, in PressureAwareFlushThroughputController the lower and upper bounds are 10x of those limits, at 100MB/sec and 200MB/sec, respectively.)

In fairly light load scenarios we see compaction quickly falls behind and write clients are backed off or failing due to RegionTooBusy exceptions. Although compaction throughput becomes unbounded after the store reaches the blocking file count, in the lead up to this the default settings do not provide enough bandwidth to stave off blocking. The defaults should be increased.

I'm not sure what new good defaults make sense. We could start by doubling them to 20MB/sec and 40MB/sec respectively. Might need to be doubled again.

Sub-Tasks

• Forward port HBASE-21000 to branch-2: Resolved
• Include HBASE-21284 to branch-2.2: Resolved